Correctly classify the files and directories that pass to watcher #37102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, autoload paths pass to the watcher as directories. If using evented watcher, this possibly pass as it is to `Listen`. But autoload paths include files and `Listen` raise an error when was passed file. So, it is necessary to classify files and directories correctly. Fixes rails#37011.
y-yagi
added a commit
that referenced
this pull request
Sep 2, 2019
Correctly classify the files and directories that pass to watcher
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Mar 6, 2020
Correctly classify the files and directories that pass to watcher #37102 rails/rails#37102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, autoload paths pass to the watcher as directories. If using evented watcher, this possibly pass as it is to
Listen.But autoload paths include files and
Listenraise an error when was passed file. So, it is necessary to classify files and directories correctly.Fixes #37011.